[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 01/14] s390x/s390-virtio-ccw: don't crash on weird RAM siz
|
From: |
Eric Farman |
|
Subject: |
Re: [PATCH v1 01/14] s390x/s390-virtio-ccw: don't crash on weird RAM sizes |
|
Date: |
Thu, 12 Sep 2024 16:28:18 -0400 |
|
User-agent: |
Evolution 3.52.4 (3.52.4-1.fc40) |
On Tue, 2024-09-10 at 19:57 +0200, David Hildenbrand wrote:
> KVM is not happy when starting a VM with weird RAM sizes:
>
> # qemu-system-s390x --enable-kvm --nographic -m 1234K
> qemu-system-s390x: kvm_set_user_memory_region: KVM_SET_USER_MEMORY_REGION
> failed, slot=0, start=0x0, size=0x244000: Invalid argument
> kvm_set_phys_mem: error registering slot: Invalid argument
> Aborted (core dumped)
>
> Let's handle that in a better way by rejecting such weird RAM sizes
> right from the start:
>
> # qemu-system-s390x --enable-kvm --nographic -m 1234K
> qemu-system-s390x: ram size must be multiples of 1 MiB
>
> Signed-off-by: David Hildenbrand <david@redhat.com>
> ---
> hw/s390x/s390-virtio-ccw.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
TIL. Thanks David!
Reviewed-by: Eric Farman <farman@linux.ibm.com>
[PATCH v1 02/14] s390x/s390-virtio-hcall: remove hypercall registration mechanism, David Hildenbrand, 2024/09/10
[PATCH v1 03/14] s390x/s390-virtio-hcall: prepare for more diag500 hypercalls, David Hildenbrand, 2024/09/10
[PATCH v1 05/14] s390x/s390-virtio-ccw: move setting the maximum guest size from sclp to machine code, David Hildenbrand, 2024/09/10