[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 11/18] tests/tcg: only read/write 64 bit words on 64 bit syste
From: |
Alex Bennée |
Subject: |
[PATCH v2 11/18] tests/tcg: only read/write 64 bit words on 64 bit systems |
Date: |
Mon, 16 Sep 2024 09:53:53 +0100 |
While the compilers will generally happily synthesise a 64 bit value
for you on 32 bit systems it doesn't exercise anything on QEMU. It
also makes it hard to accurately compare the accesses to test_data
when instrumenting.
Message-Id: <20240910140733.4007719-21-alex.bennee@linaro.org>
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
v2
- >= test of __SIZEOF_POINTER__
---
tests/tcg/multiarch/system/memory.c | 26 +++++++++++++++++++-------
1 file changed, 19 insertions(+), 7 deletions(-)
diff --git a/tests/tcg/multiarch/system/memory.c
b/tests/tcg/multiarch/system/memory.c
index 8f2371975d..28080767b2 100644
--- a/tests/tcg/multiarch/system/memory.c
+++ b/tests/tcg/multiarch/system/memory.c
@@ -163,6 +163,7 @@ static void init_test_data_u32(int offset)
ml_printf("done %d @ %p\n", i, ptr);
}
+#if __SIZEOF_POINTER__ >= 8
static void init_test_data_u64(int offset)
{
uint8_t count = 0;
@@ -187,6 +188,7 @@ static void init_test_data_u64(int offset)
}
ml_printf("done %d @ %p\n", i, ptr);
}
+#endif
static bool read_test_data_u16(int offset)
{
@@ -254,6 +256,7 @@ static bool read_test_data_u32(int offset)
return true;
}
+#if __SIZEOF_POINTER__ >= 8
static bool read_test_data_u64(int offset)
{
uint64_t word, *ptr = (uint64_t *)&test_data[offset];
@@ -307,11 +310,16 @@ static bool read_test_data_u64(int offset)
ml_printf("done %d @ %p\n", i, ptr);
return true;
}
+#endif
/* Read the test data and verify at various offsets */
-read_ufn read_ufns[] = { read_test_data_u16,
- read_test_data_u32,
- read_test_data_u64 };
+read_ufn read_ufns[] = {
+ read_test_data_u16,
+ read_test_data_u32,
+#if __SIZEOF_POINTER__ >= 8
+ read_test_data_u64
+#endif
+};
bool do_unsigned_reads(int start_off)
{
@@ -476,10 +484,14 @@ bool do_signed_reads(bool neg_first)
return ok;
}
-init_ufn init_ufns[] = { init_test_data_u8,
- init_test_data_u16,
- init_test_data_u32,
- init_test_data_u64 };
+init_ufn init_ufns[] = {
+ init_test_data_u8,
+ init_test_data_u16,
+ init_test_data_u32,
+#if __SIZEOF_POINTER__ >= 8
+ init_test_data_u64
+#endif
+};
int main(void)
{
--
2.39.5
- [PATCH v2 00/18] tcg plugins pre-PR (deprecations, mem apis, contrib plugins), Alex Bennée, 2024/09/16
- [PATCH v2 04/18] plugins: save value during memory accesses, Alex Bennée, 2024/09/16
- [PATCH v2 02/18] deprecation: don't enable TCG plugins by default with TCI, Alex Bennée, 2024/09/16
- [PATCH v2 05/18] plugins: extend API to get latest memory value accessed, Alex Bennée, 2024/09/16
- [PATCH v2 03/18] contrib/plugins: control flow plugin, Alex Bennée, 2024/09/16
- [PATCH v2 10/18] tests/tcg: clean up output of memory system test, Alex Bennée, 2024/09/16
- [PATCH v2 06/18] tests/tcg: add mechanism to run specific tests with plugins, Alex Bennée, 2024/09/16
- [PATCH v2 09/18] tests/tcg/multiarch: add test for plugin memory access, Alex Bennée, 2024/09/16
- [PATCH v2 11/18] tests/tcg: only read/write 64 bit words on 64 bit systems,
Alex Bennée <=
- [PATCH v2 12/18] tests/tcg: ensure s390x-softmmu output redirected, Alex Bennée, 2024/09/16
- [PATCH v2 08/18] tests/tcg/plugins/mem: add option to print memory accesses, Alex Bennée, 2024/09/16
- [PATCH v2 01/18] deprecation: don't enable TCG plugins by default on 32 bit hosts, Alex Bennée, 2024/09/16
- [PATCH v2 07/18] tests/tcg: allow to check output of plugins, Alex Bennée, 2024/09/16
- [PATCH v2 18/18] contrib/plugins: avoid hanging program, Alex Bennée, 2024/09/16
- [PATCH v2 14/18] util/timer: avoid deadlock when shutting down, Alex Bennée, 2024/09/16