[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-stable] [PATCH v2] job: Fix nested aio_poll() hanging in job_t
From: |
Fam Zheng |
Subject: |
Re: [Qemu-stable] [PATCH v2] job: Fix nested aio_poll() hanging in job_txn_apply |
Date: |
Tue, 4 Sep 2018 09:02:04 +0800 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Fri, 08/24 10:43, Fam Zheng wrote:
> All callers have acquired ctx already. Doing that again results in
> aio_poll() hang. This fixes the problem that a BDRV_POLL_WHILE() in the
> callback cannot make progress because ctx is recursively locked, for
> example, when drive-backup finishes.
>
> There are two callers of job_finalize():
>
> address@hidden:~/work/qemu [master]$ git grep -w -A1 '^\s*job_finalize'
> blockdev.c: job_finalize(&job->job, errp);
> blockdev.c- aio_context_release(aio_context);
> --
> job-qmp.c: job_finalize(job, errp);
> job-qmp.c- aio_context_release(aio_context);
> --
> tests/test-blockjob.c: job_finalize(&job->job, &error_abort);
> tests/test-blockjob.c- assert(job->job.status == JOB_STATUS_CONCLUDED);
>
> Ignoring the test, it's easy to see both callers to job_finalize (and
> job_do_finalize) have acquired the context.
>
> Cc: address@hidden
> Reported-by: Gu Nini <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> Signed-off-by: Fam Zheng <address@hidden>
Ping?
- Re: [Qemu-stable] [PATCH v2] job: Fix nested aio_poll() hanging in job_txn_apply,
Fam Zheng <=