[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] io: remove io watch if TLS channel is closed during handshak
From: |
Michael Tokarev |
Subject: |
Re: [PATCH] io: remove io watch if TLS channel is closed during handshake |
Date: |
Wed, 12 Jul 2023 12:15:56 +0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 |
07.07.2023 12:38, Daniel P. Berrangé wrote:
On Fri, Jul 07, 2023 at 01:30:16PM +0400, Marc-André Lureau wrote:
...>>> @@ -378,6 +380,10 @@ static int qio_channel_tls_close(QIOChannel *ioc,
{
QIOChannelTLS *tioc = QIO_CHANNEL_TLS(ioc);
+ if (tioc->hs_ioc_tag) {
+ g_source_remove(tioc->hs_ioc_tag);
set it to 0 ?
or
g_clear_handle_id(&tios->hs_ioc_tag, g_source_remove);
Yes, close can be called mutliple times, so we must set to zero.
Ping, for qemu 8.1 and -stable ?
Thanks,
/mjt