[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Revert "virtio-scsi: Send "REPORTED LUNS CHANGED" sense data
|
From: |
Christoph Hellwig |
|
Subject: |
Re: [PATCH] Revert "virtio-scsi: Send "REPORTED LUNS CHANGED" sense data upon disk hotplug events" |
|
Date: |
Wed, 12 Jul 2023 06:40:20 -0700 |
On Wed, Jul 12, 2023 at 10:28:00AM +0200, Stefano Garzarella wrote:
> The problem is that the SCSI stack does not send this command, so we
> should do it in the driver. In fact we do it for
> VIRTIO_SCSI_EVT_RESET_RESCAN (hotplug), but not for
> VIRTIO_SCSI_EVT_RESET_REMOVED (hotunplug).
No, you should absolutely no do it in the driver. The fact that
virtio-scsi even tries to do some of its own LUN scanning is
problematic and should have never happened.
Re: [PATCH] Revert "virtio-scsi: Send "REPORTED LUNS CHANGED" sense data upon disk hotplug events", Mike Christie, 2023/07/11
Re: [PATCH] Revert "virtio-scsi: Send "REPORTED LUNS CHANGED" sense data upon disk hotplug events", Paolo Bonzini, 2023/07/12