[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 1/4] migration/qmp: Fix crash on setting tls-authz with nu
|
From: |
Markus Armbruster |
|
Subject: |
Re: [PATCH v3 1/4] migration/qmp: Fix crash on setting tls-authz with null |
|
Date: |
Mon, 16 Oct 2023 08:05:05 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Advice for next time...
Peter Xu <peterx@redhat.com> writes:
> QEMU will crash if anyone tries to set tls-authz (which is a type
> StrOrNull) with 'null' value. Fix it in the easy way by converting it to
> qstring just like the other two tls parameters.
Include a reproducer whenever practical. Helps backporters. It would
have been practical here:
QEMU will crash if anyone tries to set tls-authz (which is a type
StrOrNull) with 'null' value. Reproducer:
{"execute": "migrate-set-parameters", "arguments": {"tls-authz": null}}
Fix it in the easy way by converting it to qstring just like the other
two tls parameters.
[...]