Re: [PATCH v3 5/5] accel/tcg: Always call tcg_flush_jmp_cache() on reset

[Michael Tokarev]

03.05.2024 15:34, Philippe Mathieu-Daudé wrote:
> In commit bb6cf6f016 ("accel/tcg: Factor tcg_cpu_reset_hold() out")
> we unfortunately restricted the tcg_flush_jmp_cache() to system
> emulation. Move it to the common tcg_exec_cpu_reset_hold() handler
> so user emulation gets the jmp_cache initialized when threads
> are created.
>
> Remove the NULL check in tcg_flush_jmp_cache() from commit 4e4fa6c12d
> ("accel/tcg: Complete cpu initialization before registration") which
> was a band-aid fix for incorrect commit bb6cf6f016.
>
> Cc: qemu-stable@nongnu.org
> Fixes: bb6cf6f016 ("accel/tcg: Factor tcg_cpu_reset_hold() out")
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Hi!

Has this change been forgotten, or is it not appropriate anymore?

Thanks,

/mjt

--
GPG Key transition (from rsa2048 to rsa4096) since 2024-04-24.
New key: rsa4096/61AD3D98ECDF2C8E  9D8B E14E 3F2A 9DD7 9199  28F1 61AD 3D98 
ECDF 2C8E
Old key: rsa2048/457CE0A0804465C5  6EE1 95D1 886E 8FFB 810D  4324 457C E0A0 
8044 65C5
Transition statement: http://www.corpit.ru/mjt/gpg-transition-2024.txt