[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH] clean-up: removed duplicate #inc
From: |
Peter Maydell |
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH] clean-up: removed duplicate #includes |
Date: |
Fri, 7 Oct 2016 15:49:27 +0100 |
On 7 October 2016 at 15:31, Eric Blake <address@hidden> wrote:
> On 10/07/2016 03:46 AM, Anand J wrote:
>> +++ b/hw/pci-bridge/pci_expander_bridge.c
>> @@ -13,7 +13,6 @@
>> #include "qemu/osdep.h"
>> #include "qapi/error.h"
>> #include "hw/pci/pci.h"
>> -#include "hw/pci/pci_bus.h"
>> #include "hw/pci/pci_host.h"
>> #include "hw/pci/pci_bus.h"
>
> Changes like this are obviously correct...
...assuming that pci_host.h doesn't implicitly depend on
pci_bus.h having been included first. Deleting the second
of the duplicate lines rather than the first might be
safer.
thanks
-- PMM
Re: [Qemu-trivial] [Qemu-devel] [PATCH] clean-up: removed duplicate #includes, Peter Maydell, 2016/10/07