[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH] disas/cris.c: Fix Coverity warning about unch
From: |
Edgar E. Iglesias |
Subject: |
Re: [Qemu-trivial] [PATCH] disas/cris.c: Fix Coverity warning about unchecked NULL |
Date: |
Mon, 9 Jan 2017 21:13:54 +0100 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Mon, Jan 09, 2017 at 07:05:59PM +0000, Peter Maydell wrote:
> Coverity (CID 1005689) warns that we don't check that
> spec_reg_info() returned non-NULL before dereferencing.
> Add the check, though as the comment notes this is
> a can't-really-happen case because the earlier constraint
> matching should have ruled out the "unknown reg" case.
>
> Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Edgar E. Iglesias <address@hidden>
> ---
> disas/cris.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/disas/cris.c b/disas/cris.c
> index 08161d1..8a1daf9 100644
> --- a/disas/cris.c
> +++ b/disas/cris.c
> @@ -2490,7 +2490,7 @@ print_with_operands (const struct cris_opcode *opcodep,
> const struct cris_spec_reg *sregp
> = spec_reg_info ((insn >> 12) & 15, disdata->distype);
>
> - if (sregp->name == NULL)
> + if (sregp == NULL || sregp->name == NULL)
> /* Should have been caught as a non-match earlier. */
> *tp++ = '?';
> else
> --
> 2.7.4
>