[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-trivial] [PULL 11/14] vl: Rewrite a fall through comment
From: |
Laurent Vivier |
Subject: |
[Qemu-trivial] [PULL 11/14] vl: Rewrite a fall through comment |
Date: |
Wed, 21 Aug 2019 13:19:44 +0200 |
From: Philippe Mathieu-Daudé <address@hidden>
GCC9 is confused by this comment when building with CFLAG
-Wimplicit-fallthrough=2:
vl.c: In function ‘qemu_ref_timedate’:
vl.c:773:15: error: this statement may fall through
[-Werror=implicit-fallthrough=]
773 | value -= rtc_realtime_clock_offset;
| ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~
vl.c:775:5: note: here
775 | case QEMU_CLOCK_VIRTUAL:
| ^~~~
cc1: all warnings being treated as errors
Rewrite the comment using 'fall through' which is recognized by
GCC and static analyzers.
Reported-by: Stefan Weil <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: John Snow <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>
---
vl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/vl.c b/vl.c
index edd5390110b2..1588dd8fc337 100644
--- a/vl.c
+++ b/vl.c
@@ -772,7 +772,7 @@ static time_t qemu_ref_timedate(QEMUClockType clock)
switch (clock) {
case QEMU_CLOCK_REALTIME:
value -= rtc_realtime_clock_offset;
- /* no break */
+ /* fall through */
case QEMU_CLOCK_VIRTUAL:
value += rtc_ref_start_datetime;
break;
--
2.21.0
- [Qemu-trivial] [PULL 00/14] Trivial branch patches, Laurent Vivier, 2019/08/21
- [Qemu-trivial] [PULL 14/14] hw/display: Compile various display devices as common object, Laurent Vivier, 2019/08/21
- [Qemu-trivial] [PULL 10/14] target/ppc: Rewrite a fall through comment, Laurent Vivier, 2019/08/21
- [Qemu-trivial] [PULL 06/14] hw/net/e1000: Fix erroneous comment, Laurent Vivier, 2019/08/21
- [Qemu-trivial] [PULL 01/14] test: Use g_strndup instead of plain strndup, Laurent Vivier, 2019/08/21
- [Qemu-trivial] [PULL 12/14] spapr_events: Rewrite a fall through comment, Laurent Vivier, 2019/08/21
- [Qemu-trivial] [PULL 13/14] hw/display/sm501: Remove unused include, Laurent Vivier, 2019/08/21
- [Qemu-trivial] [PULL 03/14] configure: remove obsoleted $sparc_cpu variable, Laurent Vivier, 2019/08/21
- [Qemu-trivial] [PULL 11/14] vl: Rewrite a fall through comment,
Laurent Vivier <=
- [Qemu-trivial] [PULL 07/14] json: Move switch 'fall through' comment to correct place, Laurent Vivier, 2019/08/21
- [Qemu-trivial] [PULL 08/14] hw/dma/omap_dma: Move switch 'fall through' comment to correct place, Laurent Vivier, 2019/08/21
- [Qemu-trivial] [PULL 02/14] misc: fix naming scheme of compatiblity arrays, Laurent Vivier, 2019/08/21
- [Qemu-trivial] [PULL 05/14] .gitignore: ignore some vhost-user* related files, Laurent Vivier, 2019/08/21
- [Qemu-trivial] [PULL 09/14] hw/ipmi: Rewrite a fall through comment, Laurent Vivier, 2019/08/21
- [Qemu-trivial] [PULL 04/14] configure: fix sdl detection using sdl2-config, Laurent Vivier, 2019/08/21
- Re: [Qemu-trivial] [PULL 00/14] Trivial branch patches, Peter Maydell, 2019/08/22