Re: [PATCH] hw/ide/ahci: Replace fprintf() by qemu_log_mask(GUEST_ERROR)

[Thomas Huth]

On 12/01/2021 12.29, Philippe Mathieu-Daudé wrote:
> Replace fprintf() calls by qemu_log_mask(LOG_GUEST_ERROR).
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>   hw/ide/ahci.c | 8 +++++---
>   1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c
> index 4b675b9cfd8..6d50482b8d1 100644
> --- a/hw/ide/ahci.c
> +++ b/hw/ide/ahci.c
> @@ -465,8 +465,9 @@ static void ahci_mem_write(void *opaque, hwaddr addr,
>   
>       /* Only aligned reads are allowed on AHCI */
>       if (addr & 3) {
> -        fprintf(stderr, "ahci: Mis-aligned write to addr 0x"
> -                TARGET_FMT_plx "\n", addr);
> +        qemu_log_mask(LOG_GUEST_ERROR,
> +                      "ahci: Mis-aligned write to addr 0x%03" HWADDR_PRIX "\n",
> +                      addr);
>           return;
>       }
>   
> @@ -1111,7 +1112,8 @@ static void process_ncq_command(AHCIState *s, int port, uint8_t *cmd_fis,
>       g_assert(is_ncq(ncq_fis->command));
>       if (ncq_tfs->used) {
>           /* error - already in use */
> -        fprintf(stderr, "%s: tag %d already used\n", __func__, tag);
> +        qemu_log_mask(LOG_GUEST_ERROR, "%s: tag %d already used\n",
> +                      __func__, tag);
>           return;
>       }
>   

Reviewed-by: Thomas Huth <thuth@redhat.com>