qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] target/rx: Fix compiler errors for build with sanitizers


From: Thomas Huth
Subject: Re: [PATCH] target/rx: Fix compiler errors for build with sanitizers
Date: Fri, 29 Jan 2021 07:13:36 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1

On 28/01/2021 18.21, Stefan Weil wrote:
gcc (Debian 10.2.1-6) 10.2.1 20210110 aborts builds with enabled sanitizers:

../../../target/rx/op_helper.c: In function ‘helper_scmpu’:
../../../target/rx/op_helper.c:213:24: error: ‘tmp1’ may be used uninitialized 
in this function [-Werror=maybe-uninitialized]
   213 |     env->psw_c = (tmp0 >= tmp1);
       |                  ~~~~~~^~~~~~~~
../../../target/rx/op_helper.c:213:24: error: ‘tmp0’ may be used uninitialized 
in this function [-Werror=maybe-uninitialized]
../../../target/rx/op_helper.c: In function ‘helper_suntil’:
../../../target/rx/op_helper.c:299:23: error: ‘tmp’ may be used uninitialized 
in this function [-Werror=maybe-uninitialized]
   299 |     env->psw_c = (tmp <= env->regs[2]);
       |                  ~~~~~^~~~~~~~~~~~~~~~
../../../target/rx/op_helper.c: In function ‘helper_swhile’:
../../../target/rx/op_helper.c:318:23: error: ‘tmp’ may be used uninitialized 
in this function [-Werror=maybe-uninitialized]
   318 |     env->psw_c = (tmp <= env->regs[2]);
       |                  ~~~~~^~~~~~~~~~~~~~~~

Rewriting the code fixes those errors.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
---

Those error are false positives, but simple code changes help the
compiler (and perhaps reviewers) to understand it better.

Stefan

Reviewed-by: Thomas Huth <thuth@redhat.com>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]