Re: [PATCH trivial] colo: examples: remove mentions of script= and (wrong) downscript=

[Michael Tokarev]

09.01.2024 05:08, Zhang, Chen :
> > -----Original Message-----
> > From: Michael Tokarev <mjt@tls.msk.ru>
> > Sent: Sunday, January 7, 2024 7:25 PM
> > To: qemu-devel@nongnu.org
> > Cc: Michael Tokarev <mjt@tls.msk.ru>; qemu-trivial@nongnu.org; Zhang,
> > Chen <chen.zhang@intel.com>; Li Zhijian <lizhijian@fujitsu.com>
> > Subject: [PATCH trivial] colo: examples: remove mentions of script= and
> > (wrong) downscript=
> >
> > There's no need to repeat script=/etc/qemu-ifup in examples, as it is already
> > in there.  More, all examples uses incorrect "down script=" (which should be
> > "downscript=").
>
> Yes, good catch.
> Reviewed-by: Zhang Chen <chen.zhang@intel.com>
>
> > ---
> > I'm not sure we need so many identical examples, and why it uses vnet=off, -
> > it looks like vnet= should also be dropped.
>
> Do you means the "vnet_hdr_support" in docs?

Nope, it was a thinko on my part, I mean vhost=off parameter - which is right 
next to script=.
Why vhost is explicitly disabled here, while it isn't even enabled by default?

And do we really need that many examples like this, maybe it's a good idea to
remove half of them and refer to the other place instead?

/mjt