Re: [PATCH] contrib/plugins/bbv.c: Start bb index from 1

[Alex Bennée]

Michael Tokarev <mjt@tls.msk.ru> writes:

> 17.12.2024 17:24, ckf104 wrote:
>> Standard simpoint tool reqeusts that index of basic block index starts from 
>> 1.
>
> While this patch is a trivial one-liner, but the underlying issue requires at 
> least
> a minimal understanding of what it is all about, what *is* bbv to begin with, 
> what
> `simpoint' is.  I'm not sure it really is a trivial material?
>
>> Signed-off-by: ckf104 <1900011634@pku.edu.cn>
>
> Do we accept such SoBs these days?

The guidance is covered here: 
https://qemu.readthedocs.io/en/master/devel/submitting-a-patch.html#patch-emails-must-include-a-signed-off-by-line

The wording: "It is the identity you choose to be known by in the
community, but should not be anonymous, nor misrepresent whom you are"
implies you should be identifiable to assert you can submit code and
currently this email only shows up for this patch so is functionally
anonymous I think?


>
> Thanks,
>
> /mjt

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro