[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Quilt-dev] [PATCH] Fix temporary file leak in mail command
From: |
Jean Delvare |
Subject: |
[Quilt-dev] [PATCH] Fix temporary file leak in mail command |
Date: |
Thu, 9 Feb 2006 19:48:37 +0100 |
Hi all,
The mail command leaks temporary files. I seem to understand that it is
done on purpose in some cases, but shoudln't we at least fix this one?
Index: quilt/mail.in
===================================================================
RCS file: /cvsroot/quilt/quilt/quilt/mail.in,v
retrieving revision 1.22
diff -u -r1.22 mail.in
--- quilt/mail.in 3 Feb 2006 12:04:31 -0000 1.22
+++ quilt/mail.in 9 Feb 2006 18:42:16 -0000
@@ -370,6 +370,7 @@
"$introduction" >&2
else
printf $"Introduction has no subject header\n"
+ rm -f $introduction
fi
exit 1
fi
My reason for suggesting this is that this codepath is explored by the
test suite, and I'd like the test suite not to leak temporary files so
that we can spot such leaks quickly when we introduce them.
Thanks,
--
Jean Delvare
- [Quilt-dev] [PATCH] Fix temporary file leak in mail command,
Jean Delvare <=