Re: [Quilt-dev] error with "Signed-off-by" names not being proper email names

[Jean Delvare]

Hi Andreas,

> > I think sendmail is checking and dying, not quilt. Quilt actually
> > doesn't seem to make any check.
> 
> quilt/scripts/edmail.in checks that.

Ah, right. I didn't even know we had that script here... Sorry for my
misleading comment.

> Recipient name encoding is a bit tricky; when there are non-ansi characters, 
> the name needs to be encoded word-wise like so,
>     Andreas =?iso-8859-1?q?Gr=FCnbacher?= <address@hidden>
> and for that we need to assume which character the 8-bit characters in the 
> input message are from.

I guess you meant non-ASCII rather than non-ANSI? Anyway, you're right,
my fix was really only addressing the dot case rather than all cases
where special handling is needed, so you fix is much better.

> > As a side note, I have noticed that "quilt mail" creates an empty file
> > named "0". Any idea why it does that? That's a bug, hm?
> 
> Because of this glitch:
> --- quilt/mail.in
> +++ quilt/mail.in
> @@ -244 +244 @@
> -                     if [ ${#para} > 0 -a ${#para} -lt 150 ]
> +                     if [ ${#para} -gt 0 -a ${#para} -lt 150 ]

Ahh, I've been looking for something like that for minutes and couldn't
get my fingers on it. Thanks for fixing that one.

-- 
Jean Delvare