Re: [Quilt-dev] error with "Signed-off-by" names not being proper email names

[Andreas Gruenbacher]

On Saturday 25 March 2006 05:31, Greg KH wrote:
> Am using 0.44, and ran into this tonight.  If using 'quilt mail' and you
> have a patch that has a "Signed-off-by" line that looks like:
>
>       Signed-off-by: Joe R. Hacker <address@hidden>
>
> quilt will complain that the name "Joe R. Hacker" is not a proper email
> name.  That is true, as it isn't quoted, but that's not required in a
> "Signed-off-by:" line (at least it isn't for Linux kernel patches.)

The Signed-off-by header is probably part of the message body. Current quilt 
has heuristics built in for handling most patches well enough. As part of 
those heuristics, it adds addresses from To: lines in patch headers to the 
To: mail header, and Signed-off-by:, Acked-by:, and Cc: to the Cc: mail 
header. It doesn't check those addresses for validity or try to quote them, 
so that's probably what causes this problem. Probably it would be good to be 
more liberal with recipient addresses in general, and quote them properly 
automatically.

Andreas