Re: [Quilt-dev] [PATCH] Fix encoding problems

[Jean Delvare]

Hi Thomas,

> Yesterday, I used Quilt to handle a couple of patches for a
> French-speaking project. And I discovered that in the editor launched
> by "quilt edit", "quilt header -e" or "quilt mail", I could not enter
> "special" characters: I was limited to the ASCII 7-bit characters. They
> might be sufficient for english-speaking people but certainly not for
> other languages ;-)
> 
> In fact, the problem comes from quilt/scripts/patchfns.in which starts
> by setting LANG to POSIX, unconditionally. So, later, editors (in quilt
> edit, quilt header -e or quilt mail) are launched with LANG=POSIX, and
> then don't allow to enter non-ASCII characters.
> 
> This problem is fixed by using LANG=$ORIGINAL_LANG before launching the
> editors in quilt edit, quilt header -e and quilt mail. ORIGINAL_LANG is
> already set by quilt/scripts/patchfns.in, just before it modifies LANG.
> 
> In quilt mail, I also fixed the charset detection: it was based on
> $LANG if $LC_ALL was empty. But $LANG is always POSIX, so it is not
> really helpful. So, we use $ORIGINAL_LANG here too.
> 
> However, there are still some problems left with mail sending. The
> subject field is not correctly encoded, the Content-Type is not
> specified. I have not yet looked enough into quilt/mail.in and in the
> edmail helper script to fix these issues.
> 
> Patch applies to current CVS.

Good catch and good analysis. Patch looks all OK to me, I just committed
it to CVS. Thanks for your contribution! And sorry for the late answer.

-- 
Jean Delvare