Re: [Quilt-dev] [PATCH] New feature QUILT_DIFF_A_B

[Jean Delvare]

Hi Markus,

[Markus Oberhumer]
> This patch introduces a new QUILT_DIFF_A_B config variable to create 
> patches prefixed with a/ and b/ directories like git and mercurial does.
> 
> Please review and apply if you find it useful.

> Index: b/quilt/scripts/patchfns.in
> ===================================================================
> --- a/quilt/scripts/patchfns.in
> +++ b/quilt/scripts/patchfns.in
> @@ -674,6 +674,10 @@
>       then
>               old_hdr=$file.orig
>               new_hdr=$file
> +     elif [ "X$QUILT_DIFF_A_B" = Xyes ]
> +     then
> +             old_hdr=a/$file
> +             new_hdr=b/$file
>       else
>               local dir=$(basename $PWD)
>               old_hdr=$dir.orig/$file

I am worried that this isn't consistent with the way we handle the
other similar variables. Other variables are considered enabled if
set to anything, and disabled if not set (or set empty.) Please do the
same for this one.

This will also cause strange "Index:" lines, as the patch above, BTW:
they'll begin with "b/" which doesn't make much sense. I think this
should be addressed before we can accept your patch.

-- 
Jean Delvare