Re: [Quilt-dev] [PATCH] New feature QUILT_DIFF_A_B

[Jean Delvare]

Hi Markus,

> attached is my next try on this issue.

And here are my comments:

> Index: b/quilt.quiltrc
> ===================================================================
> --- a/quilt.quiltrc
> +++ b/quilt.quiltrc
> @@ -21,3 +21,26 @@
>  # Use a specific editor for quilt (defaults to the value of $EDITOR before
>  # sourcing this configuration file, or vi if $EDITOR wasn't set).
>  #EDITOR=nedit
> +
> +#########################################################
> +
> +# If you want to keep your patches in a somewhat canonical form
> +# to ease version control management or sharing you might
> +# want to use the following settings:
> +
> +#   Establish a canonical sort order for filename sorting
> +#   (see "man sort" or "info sort" for details).
> +export LC_COLLATE=C
> +
> +#   Use "a/" and "b/" as directory prefix for diffs.
> +QUILT_DIFF_A_B=yes
> +#   Do not prefix the name of the patches themselves.
> +QUILT_PATCHES_PREFIX=

This is the default so you don't need this line.

> +
> +#   Sort filenames within patches, do not record timestamps.
> +QUILT_DIFF_ARGS="--sort --no-timestamps --color=auto"
> +QUILT_REFRESH_ARGS="--sort --no-timestamps"
> +
> +#   Colored output is nice.
> +QUILT_PUSH_ARGS="--color=auto"
> +

It might be nice, but this is also completely unrelated ;)

Anyway, all this should be commented out. I see no reason to make this
the default.

> Index: b/test/test.quiltrc
> ===================================================================
> --- a/test/test.quiltrc
> +++ b/test/test.quiltrc
> @@ -3,4 +3,5 @@
>  QUILT_REFRESH_ARGS="--no-timestamps"
>  QUILT_MAIL_ARGS="--charset=UTF-8"
>  
> +QUILT_DIFF_A_B=
>  QUILT_PATCHES_PREFIX=yes
> 

This is the default so you don't need this line either.

-- 
Jean Delvare