Re: [Quilt-dev] [PATCH] New feature QUILT_DIFF_A_B

[Andreas Gruenbacher]

On Tuesday, 27. June 2006 22:51, Anders Larsen wrote:
> On 2006-06-27 22:21:39, Andreas Gruenbacher wrote:
> > Anders,
> >
> > On Tuesday, 27 June 2006 13:35, Anders Larsen wrote:
> > > Hi,
> > >
> > > the version in CVS incorrectly appends the string -pab to the patch
> > > name in the series file, which causes 'quilt push' to fail.
> > > Also, it passes -pab (instead of -p1) to diffstat, so that all paths
> > > in the diffstat start with b/, which looks a bit strange...
> >
> > could you please try the current cvs and see if I got it all right?
>
> Not quite there yet; 'quilt push' works again, although the 'series'
> file still contains '-pab' after the patch name.

This is by design. Unless defined otherwise, a patch will remain in the same 
style as defined in the series file; "a/b" style in this case.

> 'quilt refresh' now prints the message:
> "...scripts/patchfns: line 716: [: ab: integer expression expected"
> but seems to refresh the patch anyway.

Happened when a patch deletes a file. Fixed.

> The '-pab' option is still passed to diffstat (should be '-p1').
>
> I have the following non-standard options in my quiltrc:
> QUILT_DIFF_ARGS="--no-timestamps --color=auto -p ab"
> QUILT_REFRESH_ARGS="--no-timestamps --backup --diffstat -p ab"

Fixed as well. Any more problems?

The "a/b style" support has become a bit messy by now :(

Andreas