[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Quilt-dev] [PATCH 22/39] backup-files: Check if backup exists
From: |
Jean Delvare |
Subject: |
Re: [Quilt-dev] [PATCH 22/39] backup-files: Check if backup exists |
Date: |
Tue, 22 Mar 2011 17:28:38 +0100 |
User-agent: |
KMail/1.12.4 (Linux/2.6.32.29-0.3-pae; KDE/4.3.5; i686; ; ) |
On Saturday 19 March 2011 10:52:52 am Jean Delvare wrote:
> Make sure that a backup exists before attempting any action which
> reads the file list from it.
I will actually have to drop this patch, as it turns out that "quilt
push" can legitimately call restore with no backup files. Restore is
called for rollback when a patch fails to apply completely. If the
failing file is the first one in the patch, the backup directory never
gets a chance to be created.
>
> Signed-off-by: Jean Delvare <address@hidden>
> Reviewed-by: Raphael Hertzog <address@hidden>
> ---
> quilt/scripts/backup-files.in | 5 +++++
> 1 file changed, 5 insertions(+)
>
> --- a/quilt/scripts/backup-files.in
> +++ b/quilt/scripts/backup-files.in
> @@ -205,6 +205,11 @@ if [ "${OPT_PREFIX:(-1)}" != / ]; then
> exit 1
> fi
>
> +if [ "$1" = - ] && [ ! -d "$OPT_PREFIX" ]; then
> + echo "Backup is missing" >&2
> + exit 1
> +fi
> +
> if [ -n "$OPT_FILE" ]; then
> cat "$OPT_FILE" \
>
> | while read nextfile; do
>
--
Jean Delvare
Suse L3
- [Quilt-dev] [PATCH 21/39] backup-files: Drop curly braces, (continued)
- [Quilt-dev] [PATCH 21/39] backup-files: Drop curly braces, Jean Delvare, 2011/03/19
- [Quilt-dev] [PATCH 07/39] backup-files: Skip test for file presence, Jean Delvare, 2011/03/19
- [Quilt-dev] [PATCH 18/39] backup-files: Make input methods mutually exclusive, Jean Delvare, 2011/03/19
- [Quilt-dev] [PATCH 25/39] backup-files: Separate function restore_all, Jean Delvare, 2011/03/19
- [Quilt-dev] [PATCH 26/39] backup-files: Quick exit when unlinking is not needed, Jean Delvare, 2011/03/19
- [Quilt-dev] [PATCH 13/39] backup-files: Split code to sparate functions, Jean Delvare, 2011/03/19
- [Quilt-dev] [PATCH 24/39] backup-files: Avoid negations, Jean Delvare, 2011/03/19
- [Quilt-dev] [PATCH 14/39] backup-files: Mass reindent, Jean Delvare, 2011/03/19
- [Quilt-dev] [PATCH 01/39] Make backup-files a shell script, Jean Delvare, 2011/03/19
- [Quilt-dev] [PATCH 22/39] backup-files: Check if backup exists, Jean Delvare, 2011/03/19
- Re: [Quilt-dev] [PATCH 22/39] backup-files: Check if backup exists,
Jean Delvare <=
- [Quilt-dev] [PATCH 12/39] backup-files: Simplify find loop, Jean Delvare, 2011/03/19
- [Quilt-dev] [PATCH 15/39] backup-files: Optimize restore, Jean Delvare, 2011/03/19
- [Quilt-dev] [PATCH 23/39] backup-files: Optimize noop, Jean Delvare, 2011/03/19
- [Quilt-dev] [PATCH 27/39] backup-files: Remember the list of files, Jean Delvare, 2011/03/19
- [Quilt-dev] [PATCH 17/39] backup-files: Drop variable filelist, Jean Delvare, 2011/03/19
- [Quilt-dev] [PATCH 09/39] backup-files: Inline copy_file and link_or_copy_file, Jean Delvare, 2011/03/19
- [Quilt-dev] [PATCH 19/39] backup-files: Use internal implementation of dirname, Jean Delvare, 2011/03/19
- [Quilt-dev] [PATCH 33/39] backup-files: Try mass copy first on copy, Jean Delvare, 2011/03/19
- [Quilt-dev] [PATCH 05/39] Clean up legacy C code, Jean Delvare, 2011/03/19
- [Quilt-dev] [PATCH 11/39] backup-files: Prefix must be a directory, Jean Delvare, 2011/03/19