[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Quilt-dev] [PATCH 4/4] Force the sender in the "quilt mail" test su
From: |
Jean Delvare |
Subject: |
Re: [Quilt-dev] [PATCH 4/4] Force the sender in the "quilt mail" test suite |
Date: |
Wed, 29 Feb 2012 17:50:17 +0100 |
User-agent: |
KMail/1.12.4 (Linux/2.6.32.54-0.3-pae; KDE/4.3.5; i686; ; ) |
Hi Raphael,
On Friday 24 February 2012 12:27:39 am Raphaël Hertzog wrote:
> That way it works even on misconfigured systems that do not have a
> FQDN configured and where "hostname -f" just returns the
> non-qualified hostname.
>
> Bug-Debian: http://bugs.debian.org/393985
> Signed-off-by: Raphaël Hertzog <address@hidden>
> ---
> test/mail.test | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/test/mail.test b/test/mail.test
> index cc8736a..d53bcb4 100644
> --- a/test/mail.test
> +++ b/test/mail.test
> @@ -10,7 +10,7 @@
>
> $ cat no-subject > patches/1.diff
> $ ls patches/ > series
> - $ quilt mail --mbox mbox --prefix "test" --subject "This is a test"
> -m "Message" + $ quilt mail --sender address@hidden --mbox mbox
> --prefix "test" --subject "This is a test" -m "Message"
>
> > Unable to extract a subject header from patches/1.diff
>
> $ cat - no-subject > patches/1.diff
> @@ -19,7 +19,7 @@
> < Acked-by: Dummy <address@hidden>
> <
>
> - $ quilt mail --mbox mbox --prefix "test" -m "Message"
> + $ quilt mail --sender address@hidden --mbox mbox --prefix "test"
> -m "Message"
>
> > Introduction has no subject header
>
> $ cat - no-subject > patches/2.diff
>
No objection in principle, but can we stick to address@hidden for fake
from/sender address as the test suite already uses? noreply.org is an
existing domain so it seems unfair to use it, even if only in a test
suite.
--
Jean Delvare
Suse L3
- [Quilt-dev] Debian patches to merge, Raphaël Hertzog, 2012/02/23
- [Quilt-dev] [PATCH 3/4] quilt mail: force locale to C when generating date for the From header, Raphaël Hertzog, 2012/02/23
- [Quilt-dev] [PATCH 4/4] Force the sender in the "quilt mail" test suite, Raphaël Hertzog, 2012/02/23
- Re: [Quilt-dev] [PATCH 4/4] Force the sender in the "quilt mail" test suite,
Jean Delvare <=
- [Quilt-dev] [PATCH 2/4] quilt: unset POSIXLY_CORRECT to ensure that patch works non-interactively, Raphaël Hertzog, 2012/02/23
- [Quilt-dev] [PATCH 1/4] Ensure quilt(1) documents the correct patches directory, Raphaël Hertzog, 2012/02/23
- Re: [Quilt-dev] [PATCH 1/4] Ensure quilt(1) documents the correct patches directory, Andreas Gruenbacher, 2012/02/24
- Re: [Quilt-dev] [PATCH 1/4] Ensure quilt(1) documents the correct patches directory, Raphael Hertzog, 2012/02/24
- Re: [Quilt-dev] [PATCH 1/4] Ensure quilt(1) documents the correct patches directory, Jean Delvare, 2012/02/24
- Re: [Quilt-dev] [PATCH 1/4] Ensure quilt(1) documents the correct patches directory, Raphael Hertzog, 2012/02/24
- Re: [Quilt-dev] [PATCH 1/4] Ensure quilt(1) documents the correct patches directory, Jean Delvare, 2012/02/24
- Re: [Quilt-dev] [PATCH 1/4] Ensure quilt(1) documents the correct patches directory, Raphael Hertzog, 2012/02/24