Re: [Quilt-dev] [PATCH v2] Avoid warnings with grep 3.8

[Jean Delvare]

On Thu, 8 Sep 2022 13:46:39 +0200, Andreas Grünbacher wrote:
> Am Do., 8. Sept. 2022 um 13:30 Uhr schrieb Jean Delvare <jdelvare@suse.de>:
> > GNU grep version 3.8 became more strict about needless quoting in
> > patterns. We have one occurrence of that in quilt, where "/"
> > characters are being quoted by default. There are cases where they
> > indeed need to be quoted (typically when used in a sed s/// command)
> > but most of the time they do not, and this results in the following
> > warning:
> >
> > grep: warning: stray \ before /
> >
> > So rename quote_bre() to quote_sed_re(), and introduce
> > quote_grep_re() which does not quote "/".
> >
> > Signed-off-by: Jean Delvare <jdelvare@suse.de>
> > ---
> > Changes since v1:
> >  * Make quote_sed_re() a separate function (suggested by Andreas
> >    Grünbacher)
> >
> > For consistency, should we rename quote_re() to quote_awk_re() (in a
> > separate patch)?  
> 
> Or perhaps even in the same patch, yes.

I prefer a separate patch to minimize the backporting efforts.

> >  quilt/diff.in             |    2 +-
> >  quilt/patches.in          |    2 +-
> >  quilt/scripts/patchfns.in |   18 ++++++++++++------
> >  quilt/upgrade.in          |    4 ++--
> >  4 files changed, 16 insertions(+), 10 deletions(-)
> >
> > --- quilt.orig/quilt/scripts/patchfns.in        2022-09-08 
> > 11:47:37.227482698 +0200
> > +++ quilt/quilt/scripts/patchfns.in     2022-09-08 13:16:01.437819905 +0200
> > @@ -79,7 +79,13 @@ array_join()
> >  }
> >
> >  # Quote a string for use in a basic regular expression.  
> 
> This comment needs updating as well now. (As will the quote_re() comment.)

OK, I'll change it to:

# Quote a string for use in a regular expression for a grep pattern.

Thanks,
-- 
Jean Delvare
SUSE L3 Support