[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [rdiff-backup-users] please resend tested patches
From: |
dean gaudet |
Subject: |
Re: [rdiff-backup-users] please resend tested patches |
Date: |
Sat, 4 Nov 2006 19:06:33 -0800 (PST) |
On Sat, 4 Nov 2006, Andrew Ferguson wrote:
> dean gaudet wrote:
> > hi... i figure it can't hurt too badly if i commit patches which i've only
> > read and not tested. can't be worse than the current situation.
>
> Thanks Dean!
>
> I'll try to do some more testing with my patches -- the only possible
> issue I anticipate is if someone does a backup on Day 1, applies the
> patches on Day 2, does a backup on Day 3, and on Day 4 tries to restore
> from Day 1. Maybe rdiff-backup will complain if, for example, it tries
> to set a creation date but cannot find one in the Day 1 backup?
>
> Other than that, they've tested well.
there's actually a test suite in the tree... i've had troubles getting it
to work (ben didn't quite document all the requirements it has, such as
your userid being 'ben' :) additional tests would be useful (as would
documentation for getting it to work).
-dean