Re: [rdiff-backup-users] Building rdiff-backup on Windows

[Josh Nisly]

Andrew Ferguson wrote:
> On Apr 8, 2008, at 10:23 AM, Josh Nisly wrote:
> > > Sounds like a flag for libcmt.lib is unnecessary, then. However, you 
> > > shouldn't simply set lflags_arg to be that, but should append to 
> > > that array. (We don't want to overwrite anything the user may have set)
> > Did you mean necessary or unncecessary? Since I'm scripting it, I can 
> > handle it either way, but including it will make it easier for others 
> > to build.
>
> If every person building on Windows will need that setup as you wrote 
> it, we can hard-code it into setup.py Since it will be coded in, a 
> flag is unnecessary. (Unless people should be able to override it? I 
> defer to you as an expert.)
I suggest we leave the flag out, and I'll simply post my script to the 
wiki so that others can build it. Building from source is not common 
enough, I think, to make it worth add the flag all the time. Attached is 
a patch to use the --librsync-dir option on windows.
> Andrew

JoshN

BTW, did the patch come through correctly as an attachment this time?

--- setup.py    2008-01-03 09:36:49.000000000 -0600
+++ setup.py    2008-04-08 08:42:22.579875000 -0500
@@ -14,7 +14,7 @@
 libname = ['rsync']
 incdir_list = libdir_list = None
 
-if os.name == 'posix':
+if os.name == 'posix' and os.name == 'nt':
        LIBRSYNC_DIR = os.environ.get('LIBRSYNC_DIR', '')
        LFLAGS = os.environ.get('LFLAGS', [])
        LIBS = os.environ.get('LIBS', [])