Re: [rdiff-backup-users] More windows patches

[Josh Nisly]

Andrew Ferguson wrote:

> On Apr 11, 2008, at 5:09 PM, Josh Nisly wrote:
> > Here's another patch for rdiff-backup on Windows. os.popen does not 
> > work correctly on Windows, so this patch uses subprocess.Popen for 
> > windows platforms.
>
>
> Great. This patch and your previous one have been committed to CVS.

Thanks! Here is the next round of patches. :-)

The SIGTERM, etc. signals are not defined (and don't really make sense) 
on Windows, so rdiff-backup-signals.patch removes them.

os.kill is not available on Windows, so there's no way from Python to 
determine whether a process is running, without using the PyWin32 
package. (We check to make sure that another rdiff-backup process isn't 
already running, so that we don't stomp on each other's data.) The 
rdiff-backup-kill.patch simply ignores the check. So here is my 
question: is it acceptable to import and use platform-specific modules? 
We would obviously need to handle it correctly if they weren't there. 
Seems like we do something similar for Mac OS X specific functionality, 
but I wanted to check.

Thanks,
JoshN

rdiff-backup-patches.tar
Description: Unix tar archive