On Nov 28, 2008, at 10:57 AM, Bilbo Baggins wrote: I followed this thread, and the posted patch helped, but not completely:
http://lists.gnu.org/archive/html/rdiff-backup-users/2008-11/msg00072.html
There is still a problem with the rmdir() function. If there is a read-only file in a subdirectory, and that whole directory is deleted, rdiff-backup fails.
To recreate the bug:
mkdir data
echo dummy > data\dummy.txt
mkdir data\subdir
echo test > data\subdir\test.txt
attrib +r data\subdir\test.txt
mkdir backup
rdiff-backup data backup
attrib -r data\subdir\test.txt
del data\subdir\test.txt
rmdir data\subdir
rdiff-backup data backup
Error:
File "rdiff_backup\rpath.pyc", line 981, in rmdir
WindowsError: [Error 145] The directory is not empty: 'backup/subdir'
|
Hi,
Good catch, and nice test case, thank you. I believe Windows gives different error codes depending on the situation or perhaps which version of Windows you are using.
I have updated the fix in CVS so that it handles this error case as well.
Andrew |