|
From: | Andrew Ferguson |
Subject: | Re: [rdiff-backup-users] Problem with incorrect file owners |
Date: | Wed, 17 Dec 2008 21:04:17 -0500 |
On Dec 15, 2008, at 2:20 PM, Александр Бойков wrote:
Please, accept this patch, which checks for incorrect file owners: ! if (uid < 65535) and (gid < 65535): ! os.chown(self.path, uid, gid) self.data['uid'] = uid self.data['gid'] = gid Without this patch rdiff-backup crashes on this files: srv18 s # ls -la ...prwsrws--- 1 10516750 256 0 Jan 1 1970 table_row_props.gifcrw---S--- 1 3414740985 226526504 0, 115 Sep 6 1944
Hi,Actually, this is a bug in Python. My fix was accepted in Python 2.5.3 and above.
You can see the Python bug report: http://bugs.python.org/issue1747858 And the rdiff-backup report which prompted it: http://savannah.nongnu.org/bugs/index.php?17851But thanks for posting about it -- I went back to the Python sources and noticed that there are two other cases which need to be patched as well (lchown and fchown).
regards, Andrew
[Prev in Thread] | Current Thread | [Next in Thread] |