[Savannah-dev] [bug #3819] Wrong Location header breaks bookmarks

[nobody]

=================== BUG #3819: LATEST MODIFICATIONS ==================
http://savannah.gnu.org/bugs/?func=detailbug&bug_id=3819&group_id=11

Changes by: Mathieu Roy <address@hidden>
Date: mer 10.09.2003 à 15:07 (Europe/Paris)

            What     | Removed                   | Added
---------------------------------------------------------------------------
            Category | Other                     | Web Interface
            Severity | 9 - Blocker               | 3 - Ordinary


------------------ Additional Follow-up Comments ----------------------------
Having a running version of savannah not up to date is not really a bug.

If you think we will forget to update the savannah copy, you can post a support 
request asking us to update our copy. If you think this bug is major (I'm not 
convinced by now, I'd rather work to be able to merge the branch and the trunk 
soon -- I changed the severity to ordinary, this bug is annoying but do not 
forbid people to use Savannah) and want us to backport the fix, it may be an 
option.

It's would be pretty unconvenient for me to spend time to close bugs when I'll 
update the running copy. In which pseudo-release the bug is fixed is provided, 
I think that's matters most.

Indeed the bug tracker, IMHO, is here to track bugs, and bugs are mostly in the 
Savannah code (or in the configuration of Savannah and related tools).



=================== BUG #3819: FULL BUG SNAPSHOT ===================


Soumis par: lo-lan-do                 Projet: Savannah                      
Signalé le: ven 30.05.2003 à 11:41
Category:  Web Interface              Severity:  3 - Ordinary               
Priority:  Normal                     Resolution:  Fixed                    
Assigned to:  yeupou                  Status:  Closed                       
Fixed Release:  DEV_2003-09-05_CERN   

Summary:  Wrong Location header breaks bookmarks

Original Submission:  My browser bookmarks include 
"https://savannah.nongnu.org/my/";, so I can either go to my personal page or to 
the login page, which would then redirect me to my personal page.  That used to 
work, until a few weeks ago, where my browser complained that it couldn't reach 
"account".  A bit of investigation showed up this:



$ curl -D- https://savannah.nongnu.org/my/

HTTP/1.1 302 Found

Date: Fri, 30 May 2003 09:31:28 GMT

Server: Apache/1.3.26 Ben-SSL/1.48 (Unix) Debian GNU/Linux PHP/4.1.2

X-Powered-By: PHP/4.1.2

Location: //account/login.php?return_to=%2Fmy%2F

Transfer-Encoding: chunked

Content-Type: text/html; charset=iso-8859-1



In other words, the redirection (Location:) header contains a relative URI.  
That is broken, and against the RFC that defines HTTP 1.1 (see 
http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.30 for the 
reference).



The header should be rewritten using an absolute URI, that includes a protocol 
and hostname.

Follow-up Comments
*******************

-------------------------------------------------------
Date: mer 10.09.2003 à 15:07        By: yeupou
Having a running version of savannah not up to date is not really a bug.

If you think we will forget to update the savannah copy, you can post a support 
request asking us to update our copy. If you think this bug is major (I'm not 
convinced by now, I'd rather work to be able to merge the branch and the trunk 
soon -- I changed the severity to ordinary, this bug is annoying but do not 
forbid people to use Savannah) and want us to backport the fix, it may be an 
option.

It's would be pretty unconvenient for me to spend time to close bugs when I'll 
update the running copy. In which pseudo-release the bug is fixed is provided, 
I think that's matters most.

Indeed the bug tracker, IMHO, is here to track bugs, and bugs are mostly in the 
Savannah code (or in the configuration of Savannah and related tools).

-------------------------------------------------------
Date: mer 10.09.2003 à 14:08        By: lo-lan-do
I'd suggest not closing this bug until the change is actually made on the real 
site.  Unless this is a bug-tracker for the code only, in which case where 
shouold I report the bug on the website?

-------------------------------------------------------
Date: mer 10.09.2003 à 11:53        By: yeupou
Fixed in the CVS.

-------------------------------------------------------
Date: mer 27.08.2003 à 20:29        By: lo-lan-do
It seems to have changed sometime in the recent weeks.  It now sends the 
following:

Location: savannah.nongnu.org/account/login.php?return_to=%2Fmy%2F



...which is still broken, as the browser now tries to fetch 
https://savannah.nongnu.org/my/savannah.nongnu.org/account/login.php?return_to=%2Fmy%2F
 and fails, obviously.  At least it fails with a 404 and not with a "host 
account not found" message, but it still isn't satisfactory.



I humbly suggest that you just add https:// in front of the URL you return.  To 
the best of my knowledge and guesswork, that's all it would take to fix this 
bug.

-------------------------------------------------------
Date: lun 02.06.2003 à 14:43        By: yeupou
It's not a relative url (starting with a slash) but a broken url.


La liste CC est vide


Il n'y a aucun fichier attaché actuellement


For detailed info, follow this link:
http://savannah.gnu.org/bugs/?func=detailbug&bug_id=3819&group_id=11

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/