savannah-hackers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[sr #110939] Adding push hook for Guix


From: Bob Proulx
Subject: [sr #110939] Adding push hook for Guix
Date: Sat, 7 Oct 2023 14:46:27 -0400 (EDT)

Follow-up Comment #4, sr #110939 (project administration):

Good to hear that it is working!  Excellent!

> Perhaps add double quotes for good measure after branch= and around the URL
that includes $branch.

That's never needed for that assignment which is internal to the shell and
therefore does not ever do word splitting. I understand the paranoia though.
Sometimes the universe is actually out to get you! :-)

But since $ref might in the case of an error contain a shell meta-character
that reference should be quoted.  Which I have done now for both of those. 
Thanks!


#!/bin/sh
wget --post-data="" -O/dev/null 
https://ci.guix.gnu.org/jobset/guix/hook/evaluate
while read oldrev newrev ref; do
    branch=$(basename "$ref")
    wget --post-data="" -O/dev/null
"https://ci.guix.gnu.org/jobset/$branch/hook/evaluate";
done


And yes, the hook was already installed and ready for you after I had said "I
have implemented the following hooks." :-)



    _______________________________________________________

Reply to this item at:

  <https://savannah.nongnu.org/support/?110939>

_______________________________________________
Message sent via Savannah
https://savannah.nongnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]