[task #16596] Submission of simphone

[simphone]

Follow-up Comment #16, task #16596 (group administration):


>> The above version also includes a fix for miniupnpcstrings.h as you
>> requested.
> 
> Thank you!  As far as I can see, though, the license isn't included in
> miniupnpc/miniupnpcstrings.h.in.

That's because miniupnpcstrings.h.in includes a license notice instead, just
like the rest of the source files of the miniupnpc third-party library.
Thought license notices instead of embedded licenses were generally ok? 

The only problem I see with this particular library is that some of its
notices mistakenly refer to its LICENSE file as LICENCE. The file had
originally been called LICENCE, but the author had renamed it to LICENSE prior
to version 1.6 and had forgotten to update license notices in his source files
with his new file name. 

Could you maybe provide some more specific instructions? I'm not sure what
exactly you expect for miniupnpc or other third party libraries in general. We
did not edit files that already had copyright and license notices, but if this
would be necessary, would be glad to oblige, as soon as I know what/how to
edit.

>> So how do we proceed from here?
> 
>>>>> Please make sure that all copyrightable files include valid copyright
>>>>> and
>>>>> license notices.
> 
> Currently, files like build/uudecode.pl don't.  Please check all files, like
> in

Of course, all files from the last tarball had been checked before the link
was posted here. I hope we haven't missed any of the files.

The uudecode.pl file is from the public domain (usenet), so it looks like it
doesn't have any copyright assigned. I had mentioned this file in our
conversation here early on, when I sent the "list of licenses". The file does
have a comment (starting from line 13) that indicates its origin. What more
can we add?



    _______________________________________________________

Reply to this item at:

  <https://savannah.nongnu.org/task/?16596>

_______________________________________________
Message sent via Savannah
https://savannah.nongnu.org/

signature.asc
Description: PGP signature