Re: sed-4.7.13-3c1e on MSVC

[Jim Meyering]

On Mon, Jan 6, 2020 at 5:32 AM Bruno Haible <address@hidden> wrote:
>
> Building sed on native Windows, with MSVC 14, nearly succeeds.
>
> 1) There is a compilation error:
>
>   CC       sed/sed-sed.obj
> sed.c
> C:\cygwin64\home\bruno\sed-4.7.13-3c1e\sed\sed.c(151): error C2381: 'usage': 
> redefinition; '__declspec(noreturn)' or '[[noreturn]]' differs
> C:\cygwin64\home\bruno\sed-4.7.13-3c1e\sed\sed.c(120): note: see declaration 
> of 'usage'
> make[2]: *** [Makefile:2874: sed/sed-sed.obj] Error 2
>
> The simple fix is to remove the forward-declaration of 'usage' in line 120.
> This forward-declaration is not needed.

Oh! Thank you. I've deleted that and have just pushed the resulting commit.

> 2) There is a compilation error in the gnulib-tests:
>
> make[2]: Entering directory 
> '/home/bruno/sed-4.7.13-3c1e/build-msvc64/gnulib-tests'
> make[2]: *** No rule to make target 'lib/netinet/in.h', needed by 'all'.  
> Stop.
> make[2]: Leaving directory 
> '/home/bruno/sed-4.7.13-3c1e/build-msvc64/gnulib-tests'
>
> The reason is the 'non-recursive-gnulib-prefix-hack': In gnulib-tests/Makefile
> it has produced the line
>
>   NETINET_IN_H = lib/netinet/in.h
>
> which is wrong; it should have produced
>
>   NETINET_IN_H = netinet/in.h
>
> since the file is to be generated in the gnulib-tests/ directory, not in the 
> lib/
> directory.
>
> I don't think the build-aux/prefix-gnulib-mk can easily make the distinction
> between .h files that are supposed to be created in lib/ vs. gnulib-tests/.
> This logic comes from gnulib-tool ultimately.

Thank you for diving in and diagnosing that. Since this appears to
affect only MSVC, I will defer working on it until after the release.