Re: outstanding patches was Re: [Simulavr-devel] "Component Version" fields added in trackers

[Joel Sherrill]

Michael N. Moran wrote:
> Joel Sherrill wrote:
>   
> > My working tree also has Michael Moran's patches in it 
> > but I don't know how people feel about me merging them at
> >  this point. I got it all merged and properly 
> > autoconf'ed. :)
> >     
>
> No way! :)
> Thanks Joel.
>
>   
No problem.  Just wanting to get this wrapped up.
> > It is a large patch and it looked to me that he was 
> > missing a bit of the patch that added command line 
> > options for the SPI.
> >     
>
> It's been a long time since I looked at the code.
> What kind of command line options would you expect?
>
>   
I have no idea but your patch added three variables to
main.cpp


+   bool use_spi_source=false;
+   bool use_spi_sink=false;
+   const char* pinmon = 0;
+

This indicates to me there might be some command line options
related to spi. :)

> > But it would be easier for him to complete the patch if 
> > 95+% was merged already.
> >     
>
> So true.
>
>   
In the RTEMS world, sometimes I will merge patches
at this point because it is easier for us to reach
the end if we are going back and forth reducing the
issues in CVS.

But I wouldn't do that on this project without asking.

So jump in folks.. merge this or not?
> > It builds find and doesn't break anything that I can tell
> >  from the standard examples and tests.
> >     
>
> That's good news, but in spite of the size of the
> changes, they were fairly isolated and straight
> forward, so I don't expect they would have a
> negative impact. As for existing tests, since
> I was just adding new features I wouldn't expect
> them to be impacted.
>
>   
I didn't see much impact on anything. If
it built, it built.  It was mostly new files.
> Did you integrate my example code as well?
>
>   
Yes.
> > If it does break something, then we need more tests. :)
> >     
>
> Indeed. I used this code extensively to verify code
> before we had a target in a previous life. The code
> tested worked unmodified in the target. I didn't
> exhaustively test all modes of operation, but the
> framework is there.
>
> I'll try to find some time to test it once you've
> merged it into CVS.
>   
I just need blessing to commit it.
> Thanks for taking the lead Joel,
>   
I actually need the SPI for my own use so you will
likely hear from me again. LOL!
> mike
>
>
>   


--
Joel Sherrill, Ph.D.             Director of Research & Development
address@hidden        On-Line Applications Research
Ask me about RTEMS: a free RTOS  Huntsville AL 35805
  Support Available             (256) 722-9985