Re: X- Header Lines Appearing in Message Body

[Dan Nelson]

In the last episode (Oct 19), Rizgar said:
> This problem seems to be also listed in support ticket #103390 at
> http://savannah.nongnu.org/support/?func=detailitem&item_id=103390
> 
> Ever since upgrading to 0.2 and SA 3.0, all of the messages tagged as
> spam appear to have most of the header information appearing in the
> body of the message, rather than in the header where it belongs. 
> Also, the normal behavior of the original message being attached to
> the SA message no longer occurs.
> 
> I use Thunderbird as my client, and I can't see this behavior, but
> every customer using Outlook Express seems to have this problem. 
> Perhaps there is some kind of newline issue when the message is
> rewritten?

It also seems to be sendmail-version dependant.  I tried reproducing
the problem on my system and couldn't.  The following patch should help
though:

http://savannah.nongnu.org/cgi-bin/viewcvs/spamass-milt/spamass-milt/spamass-milter.cpp.diff?r1=1.84&r2=1.85

diff -u -r1.84 -r1.85
--- spamass-milt/spamass-milt/spamass-milter.cpp        2004/09/21 21:04:51     
1.84
+++ spamass-milt/spamass-milt/spamass-milter.cpp        2004/09/24 04:42:16     
1.85
@@ -671,6 +671,10 @@
          }
        }
   }
+
+  /* if the header line ends in \r\n, don't return the \r */
+  if (header[field_end-1] == '\r')
+       field_end--;
 
   //  Maybe remove the whitespace picked up when a header wraps - this
   //  might actually be a requirement

 

-- 
        Dan Nelson
        address@hidden