Re: [sysvinit-devel] insserv no longer understand X-Interactive: true

[Dr. Werner Fink]

On Fri, May 07, 2010 at 05:41:58PM +0200, Petter Reinholdtsen wrote:
> [Werner Fink]
> > Please try out the attached patch
> 
> Thank you.  Kel proposed a very similar patch earlier today, which
> worked for me.  Sorry I have been to busy to pass it on before now.
> 
> Description: Fix regular expression match for X-Interactive keyword, it was
>  off-by-one match group and thus always returned 'X-'.
> From: Kel Modderman <address@hidden>
> ---
> --- a/insserv.c
> +++ b/insserv.c
> @@ -1378,10 +1378,10 @@ static uchar scan_lsb_headers(const int
>               description = empty;
>       }
>  
> -     if (!interactive    && regexecutor(&reg.interact,      COMMON_ARGS) == 
> true) {
> -         if (val->rm_so < val->rm_eo) {
> -             *(pbuf+val->rm_eo) = '\0';
> -             interactive = xstrdup(pbuf+val->rm_so);
> +     if (!interactive    && regexecutor(&reg.interact,  COMMON_SHD_ARGS) == 
> true) {
> +         if (shl->rm_so < shl->rm_eo) {
> +             *(pbuf+shl->rm_eo) = '\0';
> +             interactive = xstrdup(pbuf+shl->rm_so);
>           } else
>               interactive = empty;
>       }

Hi Petter,

you may try out the attached patch as this not only includes the patch
above but also implements a new option `--recursive' to enable all
required services for the specified service.  Beside this a small bug
has been fixed. Now also alias provides of a script will be placed
within the makefiles .depend.*

        Werner

-- 
  "Having a smoking section in a restaurant is like having
          a peeing section in a swimming pool." -- Edward Burr

insserv-1.14.0.dif
Description: Text Data