branch master updated: * tp/Texinfo/XS/parsetexi/end_line.c (end_line_misc_line): remove the popping of contents at the end of a root command, there is nothing to pop, and if there was, it should be fixed directly.

[Patrice Dumas]

This is an automated email from the git hooks/post-receive script.

pertusus pushed a commit to branch master
in repository texinfo.

The following commit(s) were added to refs/heads/master by this push:
     new 7e070832bf * tp/Texinfo/XS/parsetexi/end_line.c (end_line_misc_line): 
remove the popping of contents at the end of a root command, there is nothing 
to pop, and if there was, it should be fixed directly.
7e070832bf is described below

commit 7e070832bfa7317a33145a7e04da79de754b6933
Author: Patrice Dumas <pertusus@free.fr>
AuthorDate: Sun Feb 5 17:27:34 2023 +0100

    * tp/Texinfo/XS/parsetexi/end_line.c (end_line_misc_line): remove the
    popping of contents at the end of a root command, there is nothing to
    pop, and if there was, it should be fixed directly.
---
 ChangeLog                          | 6 ++++++
 tp/TODO                            | 3 ---
 tp/Texinfo/XS/parsetexi/end_line.c | 7 -------
 3 files changed, 6 insertions(+), 10 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 692a6b02af..436e5f17e4 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2023-02-05  Patrice Dumas  <pertusus@free.fr>
+
+       * tp/Texinfo/XS/parsetexi/end_line.c (end_line_misc_line): remove the
+       popping of contents at the end of a root command, there is nothing to
+       pop, and if there was, it should be fixed directly.
+
 2023-02-05  Patrice Dumas  <pertusus@free.fr>
 
        * tp/Texinfo/ParserNonXS.pm (_transfer_source_marks),
diff --git a/tp/TODO b/tp/TODO
index 62fc5ea799..73414e7422 100644
--- a/tp/TODO
+++ b/tp/TODO
@@ -24,9 +24,6 @@ check that there is a test of something like
 
 @syncodeindex@cpfn{}
 
-in XS parser
-FIXME there is no such code in the pure perl parser
-
 Bugs
 ====
 
diff --git a/tp/Texinfo/XS/parsetexi/end_line.c 
b/tp/Texinfo/XS/parsetexi/end_line.c
index 3dc28537de..8d87555aa2 100644
--- a/tp/Texinfo/XS/parsetexi/end_line.c
+++ b/tp/Texinfo/XS/parsetexi/end_line.c
@@ -1946,13 +1946,6 @@ end_line_misc_line (ELEMENT *current)
       if (cmd == CM_node)
         counter_pop (&count_remaining_args);
       
-      /* Destroy all contents (TODO: check why do we do this?) */
-      /* FIXME there is no such code in the pure perl parser,
-         and it would be better to remove if not useful, as
-         if useful source mark information is lost */
-      while (last_contents_child (current))
-        destroy_element (pop_element_from_contents (current));
-
       /* Set 'associated_section' extra key for a node. */
       if (cmd != CM_node && cmd != CM_part)
         {