branch master updated: * tp/Texinfo/XS/convert/convert_html.c, tp/Texinfo/XS/main/errors.c: add "%s" format for fprintf instead of using a string as format. Report from Gavin.

[Patrice Dumas]

This is an automated email from the git hooks/post-receive script.

pertusus pushed a commit to branch master
in repository texinfo.

The following commit(s) were added to refs/heads/master by this push:
     new a980e50ffe * tp/Texinfo/XS/convert/convert_html.c, 
tp/Texinfo/XS/main/errors.c: add "%s" format for fprintf instead of using a 
string as format. Report from Gavin.
a980e50ffe is described below

commit a980e50ffe16d3367b61f13d7225a0d63eb3ceca
Author: Patrice Dumas <pertusus@free.fr>
AuthorDate: Fri Nov 3 09:46:36 2023 +0100

    * tp/Texinfo/XS/convert/convert_html.c, tp/Texinfo/XS/main/errors.c:
    add "%s" format for fprintf instead of using a string as format.
    Report from Gavin.
---
 ChangeLog                            | 6 ++++++
 tp/TODO                              | 6 ++++++
 tp/Texinfo/XS/convert/convert_html.c | 2 +-
 tp/Texinfo/XS/main/errors.c          | 2 +-
 4 files changed, 14 insertions(+), 2 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 6c1b9545b1..4acfba2b9a 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2023-11-03  Patrice Dumas  <pertusus@free.fr>
+
+       * tp/Texinfo/XS/convert/convert_html.c, tp/Texinfo/XS/main/errors.c:
+       add "%s" format for fprintf instead of using a string as format.
+       Report from Gavin.
+
 2023-11-03  Patrice Dumas  <pertusus@free.fr>
 
        * tp/Texinfo/Convert/HTML.pm (converter_initialize),
diff --git a/tp/TODO b/tp/TODO
index bd437824cb..11b1d38707 100644
--- a/tp/TODO
+++ b/tp/TODO
@@ -732,3 +732,9 @@ for file in t/*.t ; do bfile=`basename $file .t`; perl -w 
$file -d 1 2>t/check_d
 export TEXINFO_XS_PARSER=0
 for file in t/*.t ; do bfile=`basename $file .t`; perl -w $file -d 1 
2>t/check_debug_differences/PL_$bfile.err ; done
 for file in t/*.t ; do bfile=`basename $file .t`; diff -u 
t/check_debug_differences/PL_$bfile.err t/check_debug_differences/XS_$bfile.err 
> t/check_debug_differences/debug_$bfile.diff; done
+
+Setting flags
+our_CFLAGS='-g -Wformat-security -Wall -Wno-parentheses -Wno-missing-braces'
+./configure "CFLAGS=$our_CFLAGS" "PERL_EXT_CFLAGS=$our_CFLAGS"
+unset our_CFLAGS
+
diff --git a/tp/Texinfo/XS/convert/convert_html.c 
b/tp/Texinfo/XS/convert/convert_html.c
index 4a9aed6fd9..527e097431 100644
--- a/tp/Texinfo/XS/convert/convert_html.c
+++ b/tp/Texinfo/XS/convert/convert_html.c
@@ -2768,7 +2768,7 @@ convert_to_html_internal (CONVERTER *self, ELEMENT 
*element,
             free (text);
         }
       text_append (&debug_str, "\n");
-      fprintf (stderr, debug_str.text);
+      fprintf (stderr, "%s", debug_str.text);
       free (debug_str.text);
     }
 
diff --git a/tp/Texinfo/XS/main/errors.c b/tp/Texinfo/XS/main/errors.c
index 37c4523ce3..00410880d6 100644
--- a/tp/Texinfo/XS/main/errors.c
+++ b/tp/Texinfo/XS/main/errors.c
@@ -214,7 +214,7 @@ message_list_document_error_internal (ERROR_MESSAGE_LIST 
*error_messages,
   error_message->error_line = error_line.text;
 
   if (conf && conf->DEBUG > 0)
-    fprintf (stderr, error_message->error_line);
+    fprintf (stderr, "%s", error_message->error_line);
 }
 
 static void