[Tlf-devel] another patch

[Joop Stakenborg]

My previous patch has caused another bug to appear which took me a while
to find. I have created a logcfg.dat with the lines:

SOUNDCARD
SIDETONE_VOLUME=70

Because the function parse_logcfg() uses strstr for string comparison,
tlf thinks we have a line with "TONE=" as the second line. At line 557
buff will now become "ONE_VOLUME=70\n\0" and atoi will gladly accept
this, causing tonestr to become "ONE".

This causes unexpected crashes at unexpected places, I have had a crash
when hitting Alt-w. The solution for this would be to use "CWTONE=" in
logcfg.dat from now on and refrain from using "TONE=", see attached
patch.

Some recommendations:
- The atoi function does no error checking, use with care.
- At some point we should stop using strstr() in parse_logcfg().

Regards,
Joop PG4I
-- 
Joop Stakenborg <address@hidden>

patch.tone
Description: Text Data