Re: [BUG] tramp (2.5.3-pre HEAD/284851265423e875d6de963922f3deb536aa2882); tramp-repository-version/tramp-repository-branch variables cause git be invoked

[Michael Albinus]

Lin Sun <sunlin7@hotmail.com> writes:

> Hi,

Hi,

> The const variables tramp-repository-version/tramp-repository-branch
> will
> be initialized with simply (request 'tramp), it chains request
> "trampver.el".
>
> These two variables it initialized with invoking the `git' program.
> When
> someone (request 'tramp) -> (request 'trampvar), it will cause the
> 'git'
> be invoked twice.
>
> For most of scenario, people don't use these two variables (except
> report a tramp bug), always invoking the "git" on initialization is a
> wast on performance.

However, it *is* important when reporting bugs. Otherwise, we have no
chance to understand which Tramp (development) version is used. There
was a reason to introduce these two constants.

Collecting this information when assembling a bug report is too late:
There could be installed already another Tramp version but the one used
to produce the bug.

> And, it also will trigger an error message when "git" not in the PATH:
>> Error running git rev-parse --abbrev-ref: (file-missing "Searching for
>> program" "no such file or directory" "git")
>
> No git invoking on the
> tramp-repository-version/tramp-repository-branch
> initializing will help on performance and avoid the error message.

Good point. I've added a check, whether the "git" executable is
installed. Will be available with Emacs 28.2 and also the next Tramp
version released on GNU ELPA.

> Please help fix this issue. Thanks

Best regards, Michael.