tramp-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] Provide completion candidates for remote containers over a TRAMP


From: Gene Goykhman
Subject: [PATCH] Provide completion candidates for remote containers over a TRAMP connection
Date: Tue, 22 Aug 2023 12:33:35 -0400
User-agent: mu4e 1.10.5; emacs 29.1

Following up on 
https://lists.gnu.org/archive/html/tramp-devel/2023-08/msg00001.html, I have 
prepared a patch to add remote container completion support to TRAMP.

A couple of questions/things I'm uncertain of in this patch:

1. I am removing the check for executable-find for the docker and podman 
programs since they need to be run on the remote system (and executable-find 
will fail as it only checks the local machine while multi-hopping). I'm not 
sure if there is a better way to handle this.

2. In tramp-set-completion-function I am short-circuiting the cond check for a 
valid "file or registry key" since again, file-exists-p will fail when checking 
for the docker or podman program on a remote system when checking a multi-hop 
path. I'm open to a better ideas here since my change effectively no-ops the 
whole cond.

3. (style question) I've added my required variable tramp-last-hop-directory as 
an autoload in tramp.el but if there's a better place for it I'd be happy to 
move it.

Attachment: 0001-Provide-completion-candidates-for-remote-containers-.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]