[Uisp-dev] Re: Uisp patch, to make device name compatible with avr-gcc

[Theodore A. Roth]

Hi Egil,

You are absolutely right that this broken.

address@hidden:~$ uisp --version
uisp version 20021005-cvs
<snip>

address@hidden:~$ uisp -dprog=pavr -dpart=at90s2313 --erase --upload --verify
-dpart: Invalid name.
address@hidden:~$ uisp -dprog=stk500 -dpart=at90s2313 --erase --upload
--verify
Programmer is not responding.

Sorry, I hadn't checked the AvrAtmel.C part and just "assumed" it worked
the same as in Stk500.C. <hangs head in shame>

I don't have your patch handy (it's on my machine at home). Could you
resend it to me?

Also, do you know why they have the BOOT versions? E.g.:

  {"M128",   0x43, "ATmega128", false},
  {"M128b",  0x44, "ATmega128 BOOT", false},

Seems that a trivial fix would be the following (ignoring the BOOT cases):

diff -u -r1.6 AvrAtmel.C
--- src/AvrAtmel.C      24 Jun 2002 13:10:43 -0000      1.6
+++ src/AvrAtmel.C      25 Oct 2002 16:59:37 -0000
@@ -533,7 +533,9 @@
     } else{
       int j;
       for (j=0; prg_part[j].name[0] != 0; j++){
-       if (strcasecmp (desired_partname, prg_part[j].name)==0){
+        if ((strcasecmp (desired_partname, prg_part[j].name)==0) ||
+            (strcasecmp (desired_partname, prg_part[j].description)==0))
+        {
          desired_avrcode = prg_part[j].code;
          break;
        }

Ted Roth

On 25 Oct 2002, Egil Kvaleberg wrote:

:) On Mon, 2002-10-21 at 17:44, Theodore A. Roth wrote:
:) > This too had been in uisp for a while now.
:)
:) Not that I can see. Here is what happened when I tried with an
:) uisp directly from the CVS tree:
:)
:) $ uisp -dprog=pavr -dpart=at90s2313 --erase --upload --verify
:) if=demo.hex
:) -dpart: Invalid name.
:) $ uisp --version
:) uisp version 20021005-cvs
:) (c) 1997-1999 Uros Platise, 2000-2002 Marek Michalkiewicz
:)
:) uisp is free software, covered by the GNU General Public License.
:) You are welcome to change it and/or distribute copies of it under
:) the conditions of the GNU General Public License.
:)
:) $
:)
:)
:) > You seem to have a pretty old version of uisp. The latest release is here:
:) >
:) >   http://savannah.nongnu.org/download/uisp/uisp-20020626.tar.gz
:)
:) That is indeed the version I have, and to which the patch applies.
:) Did you read my comment at all? perhaps it was unclear?
:)
:) Egil Kvaleberg
:) --
:) Email: address@hidden
:) Voice/videophone: +47 22523641 Voice: +47 92022780 Fax: +47 22525899
:) Mail:  Egil Kvaleberg, Husebybakken 14A, 0379 Oslo, Norway
:) Home:  http://www.kvaleberg.com/
:)