Re: [Uisp-dev] A second patch

[Theodore A. Roth]

On Thu, 30 Sep 2004, Margarita Manterola wrote:

> Hi!
>
> There was something weird in the patch I sent a couple of days ago,
> and it was the need of a non-inverted reset, when AT89XXX micro
> controllers _do_ have a reset that is the inverted AVR's reset.
>
> After talking this over with Wojtek Kaniewski and investigating a bit
> more, I found a page that explained what was happening:
> http://www.beyondlogic.org/spp/parallel.htm#2
>
> The cable I'm using is the ATDH, which resets through pin 17, which is
> hardware inverted.  Seeing this, I made a few changes to the patch,
> dropping my -d89S52 parameter, and adding the inverted reset directly
> to the cable configuration.
> I also added a couple of comments about the pins that are low active.
>
> Also, I changed the way in which the -dinvert parameter works.
> Instead of setting the values directly to 1, it switches the value the
> parameter has to its contrary.
>
> This patch is a little bit more intrusive than the other one, but I
> think it's quite better. As the previous one, it's done taking the
> latest release (20040311) as base.
>
> Please tell me what you think of it.

Looks fine to me. I'll try to get it into cvs later today.

Thanks for the patch.

---
Ted Roth
PGP Key ID: 0x18F846E9
Jabber ID: address@hidden