[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Remove obsolete gcc pragma
From: |
Thomas Dickey |
Subject: |
Re: [PATCH] Remove obsolete gcc pragma |
Date: |
Mon, 4 Jul 2022 05:09:17 -0400 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Mon, Jul 04, 2022 at 02:20:15PM +1000, Brendan O'Dea wrote:
> Remove a pragma from perl.xs which gcc no longer recognises.
>
> This pragma was meant to reduce noise, but now adds more. Compiling
> with gcc 11 produces:
That's a recent change, from December. My checkin comment says
quiet another, used in OpenSUSE and Slackware
> ../../perl.xs:24:32: warning: unknown option after ‘#pragma GCC diagnostic’
> kind [-Wpragmas]
> 24 | #pragma GCC diagnostic ignored "-Wcompound-token-split-by-macro"
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> diff --git a/perl.xs b/perl.xs
> index 646f2ed..86c04e3 100644
> --- a/perl.xs
> +++ b/perl.xs
> @@ -21,7 +21,6 @@
> */
> #ifdef __GNUC__
> #pragma GCC diagnostic ignored "-Wcast-qual"
> -#pragma GCC diagnostic ignored "-Wcompound-token-split-by-macro"
--
Thomas E. Dickey <dickey@invisible-island.net>
https://invisible-island.net
ftp://ftp.invisible-island.net
signature.asc
Description: PGP signature