wget-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: wget2 | * tests/test-timestamping.c: Pass correct type to variadic f


From: @rockdaboot
Subject: Re: wget2 | * tests/test-timestamping.c: Pass correct type to variadic function (!538)
Date: Sat, 20 Jan 2024 12:05:38 +0000



Tim Rühsen commented on a discussion on tests/test-timestamping.c: 
https://gitlab.com/gnuwget/wget2/-/merge_requests/538#note_1735147614

>               },
>       };
>  
> -     int n_urls = countof(urls);
>       // functions won't come back if an error occurs
>       wget_test_start_server(
> -             WGET_TEST_RESPONSE_URLS, &urls, n_urls,
> +             WGET_TEST_RESPONSE_URLS, &urls, countof(urls),
>               WGET_TEST_FEATURE_MHD,
>               0);
>  
> +     int n_urls = countof(urls);

Oh, that's great you found it!

In hindsight, it's maybe a bad idea to use variable arguments. There is no 
type-safety for them.

-- 
Reply to this email directly or view it on GitLab: 
https://gitlab.com/gnuwget/wget2/-/merge_requests/538#note_1735147614
You're receiving this email because of your account on gitlab.com.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]