[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] Makefile: do not call ar directly
From: |
Hoël Bézier |
Subject: |
[PATCH] Makefile: do not call ar directly |
Date: |
Sat, 6 Nov 2021 21:02:33 +0100 |
Hi!
I’ve now improved support for lzip compression in ./play.it and it awaits
approval to be merged, thanks to you.
Testing my contribution, I found out that plzip and tarlz are not considered
stable on Gentoo, although they are on Debian. This might be because of a “bug”
in lzlib, as reported here: https://bugs.gentoo.org/721916 The bug report
targets lzlib-1.11, but I’ve been able to reproduce it with lzlib-1.12.
The issue is lzlib Makefile calls ar directly, instead of using the AR
variable. This is undesirable on Gentoo to prevent issues while
cross-compiling, for example. I’ve seen that the Makefile handles CC correctly
however, so all one needs to do is to write some similar instructions for AR.
Since this does not seem too hard to fix, I figured I would do it myself. So
I’ve attached the patch I wrote. I’ve tested this, and this seems to do the
trick.
Of course, the ebuild used to compile the library on Gentoo also needs to be
patched, and if I’m not mistaken, you’re the maintainer, so I’ve attached my
patch to the ebuild as well. If you’re not, well tell me and I’ll open an issue
on Gentoo bugtracker myself. :)
Any comments are welcome,
Hoël
undefine-ar.patch
Description: Text Data
lzlib-1.12-ebuild.patch
Description: Text Data
signature.asc
Description: PGP signature
- [PATCH] Makefile: do not call ar directly,
Hoël Bézier <=