Re: [Adonthell-devel] Audio feedback

[Chris Frey]

On Wed, Jun 27, 2012 at 08:41:45PM +0200, Josh Glover wrote:
> For those of you with a computer, you can checkout the
> gui-audio-feedback branch:
> 
> https://github.com/ksterker/adonthell/tree/gui-audio-feedback
> 
> Run worldtest to hear the excitement. You should hear the background
> music fade in as worldtest starts. Enter a conversation with the guy,
> and you should hear clicks as you select responses.

Nice! :-)  Sound works great here.

On my build, I get a signed comparision warning, so I'd suggest this
change, since the source comparisons are pointers anyway, and probably want
to compare as unsigned every time.


diff --git a/src/gui/ui_event.h b/src/gui/ui_event.h
index 4339d4d..dd5434b 100644
--- a/src/gui/ui_event.h
+++ b/src/gui/ui_event.h
@@ -45,7 +45,7 @@ namespace gui
         /**
          * Source for listeners that want to listen to events of a given type f
          */
-        static const int ANY_SOURCE = 0x1; // definitely not a valid pointer
+        static const unsigned int ANY_SOURCE = 0x1; // definitely not a valid p
 
         /**
          * @name Initialization


I'll let Kai do the official code review. :-)

- Chris