Re: [Adonthell-devel] Audio feedback

[Kai Sterker]

On Wed, Jun 27, 2012 at 8:41 PM, Josh Glover <address@hidden> wrote:

> Before merging to master, I wanted to get a quick design / code review
> from you or anyone else who is interested. Here's the patch:

Looks good to me, Josh. I like the idea of using ui events and adding
the ANY_SOURCE logic.

The one thing I noticed is that the click seems to play only after the
UI has already changed. Not sure if there's a pause at the beginning
of the click sound, or if it's simpy too long. Btw., the "original" WE
click sound can be found at:

  https://github.com/ksterker/wastesedge/blob/master/audio/select.wav


The one thing missing to match v0.3 would be to fire an event when the
selected list item changes. That would be in layout::keydown. The
sound used was this one:

  https://github.com/ksterker/wastesedge/blob/master/audio/switch.wav


Hope I haven't swapped the two sounds, but judging by the names it
should be the way I described it.

Kai