Re: [Automake-NG] [RFC] [ng] cleanup: merge '%compile_clean_files' in '%clean_files'

[Stefano Lattarini]

On 06/22/2012 09:11 AM, Akim Demaille wrote:
> 
> Le 21 juin 2012 à 22:19, Stefano Lattarini a écrit :
> 
>> No need to keep them separated anymore.
>>
>> * automake.in (%libtool_clean_directories): Delete.
>> (initialize_per_input): Don't reset it.
>> (handle_compile): Don't merge '%libtool_clean_directories' (after
>> proper editing) into '%clean_dirs'.
>> (handle_ltlibraries, handle_programs, handle_single_transform):
>> Update '%clean_dirs', rather than '%libtool_clean_directories'.
>>
>> Signed-off-by: Stefano Lattarini <address@hidden>
>> ---
>>
>> I've written this patch only because I said in a previous reply that
>> I would have done so, but I really think it should be dropped, because
>> it makes the code more brittle and harder to understand.  WDYT?
> 
> I'm not sure I understand in what way the proposed code
> is harder to understand and maintain than the current
> one,
>
Basically, the knowledge about '.libs' needing to e cleaned is scattered
in several places rather than centralized into one.

In addition, this issue will probably become moot, since I plan to drop
support for older libtools and to assume that "libtool --mode=clean"
works correctly, so that we can start using that to implement libtool
related cleanups (better to rely on libtool embedded logic/knowledge
rather than duplicating it in our makefiles).

> but if you fear it, don't do it.
> 
Thanks.  So let's drop this patch, at least until I've had a change
to play with "libtool --mode=clean" and see how that works out.

Regards,
  Stefano