Re: [PATCH] Tests: remove useless repetitions of `foreign' automake option.

[Ralf Wildenhues]

* Stefano Lattarini wrote on Sat, Jun 26, 2010 at 01:40:49PM CEST:
> At Saturday 26 June 2010, Ralf Wildenhues wrote:
> > or is that always just used
> > in order to save on generating the GNU-specific files?
> This should be the real reason, yes (and is also the reason why
> --foreign is appended to $AUTOMAKE in tests/defs, BTW).
> 
> Just to be sure, I first added `gnu' to AUTOMAKE_OPTIONS in every
> Makefile.am generated by those modified tests, which subsequently
> all failed.  Then I made sure that the files required by gnu mode were
> created by each test before running automake:
>   $ sed -i 
> 's/.*\$AUTOMAKE.*/:>INSTALL;:>NEWS;:>README;:>AUTHORS;:>ChangeLog;:>COPYING\n&/'
> All the tests passed again.
> 
> So I think the patch is safe.  If you want to check directly, I have
> attached the temporary patches used in the described testing.

Thanks for verifying.  The original patch is ok for maint then if you
rewrite the log entry to prepend tests/ before the changed file names
and update copyright years.  If that isn't needed in your tree because
you have updated them in other pending patches already, ignore this
request.

Thanks,
Ralf